Description

• Updated all telemetry component methods to use pointer receivers in order to preserve any assignments within these methods.
• Pass on the analytics and Kubernetes clients as arguments instead of storing them in the struct.
• Remove the internal analyticsClient abstraction, which was basically a copy of the analytics.Client interface.
• Replace segment token checks with a global one that prevents the component from being added in the first place.
• Use the version constant directly in the telemetry instead of carrying it along in a struct field.
• Have the storage type stored as a struct field, instead of getting it from the cluster configuration. The storage type is part of the node config and cannot be reconciled.
• Add a mutex: The Start/Stop methods and the Reconcile method may be called concurrently by different goroutines. Ensure that there's no races when starting and stopping the telemetry loop. Also replace the bespoke for loop with wait.UntilWithContext, which is tailor-made for that purpose.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings